feat: Fast upgrades: upgrade payload section in blocks - #11655
Merged
Merged
Conversation
First step of the Phase-2 rolling-reboot consensus protocol, which adds the data types and the artifact mechanism. * Add `UpgradePermitAction` (`Request` / `Authorize` / `Return`). `UpgradePermitAuthorizationRequest` is the signed content, `UpgradePermitAuthorizationShare` is the gossiped artifact. * Add the in-memory `UpgradePermitAuthPoolImpl` which is modeled after other pools. * Add the `ic-consensus-upgrade` crate with `UpgradePermitAuthPoolManager`. It signs shares for requests in finalized blocks and validates gossiped shares. * Register the new proto file with the generator and add `UpgradePermitAuthorizationRequest` (signing) and `UpgradePermitAuthorizationShare` (pool-ID hashing) domain separators.
Add the upgrade section to block payloads and wire it into the payload builder infrastructure (with a placeholder builder for now). - Add `upgrade_payload_bytes` to the `Block` proto and upgrade to `BatchPayload`/`BatchMessages` - Add an `Upgrade` section to `BatchPayloadSectionBuilder` - Add the `ic-consensus-upgrade` crate with a placeholder `UpgradePayloadBuilder`
|
✅ No security or compliance issues detected. Reviewed everything up to b242534. Security OverviewDetected Code Changes
|
alin-at-dfinity
left a comment
alin-at-dfinity
left a comment
Contributor
There was a problem hiding this comment.
The change overall LGTM, but I'll leave it to Leo or Pierugo to approve, particularly since I'm not sure what the changed hashes in the crypto_hash_stability tests imply.
Co-authored-by: Pierugo Pace <pierugo.pace@dfinity.org>
…st-upgrades-block-payload
frankdavid
removed this pull request from stack #11656
September 24, 2026 13:33
Base automatically changed from
frankdavid/fast-upgrades-consensus1
to
master
September 24, 2026 14:41
…rades-block-payload # Conflicts: # rs/types/types/src/crypto/hash/tests.rs
pierugo-dfinity
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the upgrade section to block payloads and wire it into the payload builder infrastructure (with a placeholder builder for now).
upgrade_payload_bytesto theBlockproto and upgrade toBatchPayload/BatchMessagesUpgradesection toBatchPayloadSectionBuilderic-consensus-upgradecrate with a placeholderUpgradePayloadBuilder